Skip to contentSkip to conversation

enic: no longer accepting 2048 descriptor size in 20.11.6

Bug 1185 [email protected] 3 participants 3 messages Mar 15, 2023

lore
Share & tools
lore

[email protected]

author Reviewed-by Hyong Youb Kim
#0 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=1185

            Bug ID: 1185
           Summary: enic: no longer accepting 2048 descriptor size in
                    20.11.6
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: [email protected]
          Reporter: [email protected]

Target Milestone: ---

Hi enic maintainers,

With openvswitch 2.15 using dpdk 20.11.6, enic driver is reporting that it cannot accept setup with default OVS number of tx descriptors (2048).

2022-08-19T16:29:38.555Z|00204|dpdk|ERR|Invalid value for nb_tx_desc(=2048),

should be: <= 256, >= 64, and a product of 32

OVS has used 2048 as default for many years and the code in 20.11.6 does not look like it changed much from previous releases either.

The commit below [0] on dpdk main branch (but not on 20.11 branch), changes how max descriptor values are calculated.

So any idea why the 2048 can no longer be used with 20.11.6 ? some commit I missed? different firmware?

or is it an incorrect calculation and the commit [0] is needed on stable branches to correct this?

Thanks.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=2119876

[0]
commit 22572e84fbda2c195707ffbb0dd6af4433d7a219

Author: John Daley <[email protected]>
Date:   Fri Jan 28 09:58:13 2022 -0800

net/enic: support max descriptors allowed by adapter

Newer VIC adapters have the max number of supported RX and TX descriptors in their configuration. Use these values as the maximums.

Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.
Reviewed-by Hyong Youb Kim
#1 lore raw

Hi John/Hyong Youb,

Not sure if you are monitoring dpdk bugzilla, but wanted to draw your attention to https://bugs.dpdk.org/show_bug.cgi?id=1185

Maybe you have some clues about it and if we need to backport the mentioned commit?

thanks,
Kevin.

-------- Forwarded Message --------
Subject: [Bug 1185] enic: no longer accepting 2048 descriptor size in 20.11.6
Date: Wed, 15 Mar 2023 17:33:52 +0000
From: [email protected]
To: [email protected]

https://bugs.dpdk.org/show_bug.cgi?id=1185

            Bug ID: 1185
           Summary: enic: no longer accepting 2048 descriptor size in
                    20.11.6
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: [email protected]
          Reporter: [email protected]

Target Milestone: ---

Hi enic maintainers,

With openvswitch 2.15 using dpdk 20.11.6, enic driver is reporting that it cannot accept setup with default OVS number of tx descriptors (2048).

2022-08-19T16:29:38.555Z|00204|dpdk|ERR|Invalid value for nb_tx_desc(=2048),

should be: <= 256, >= 64, and a product of 32

OVS has used 2048 as default for many years and the code in 20.11.6 does not look like it changed much from previous releases either.

The commit below [0] on dpdk main branch (but not on 20.11 branch), changes how max descriptor values are calculated.

So any idea why the 2048 can no longer be used with 20.11.6 ? some commit I missed? different firmware?

or is it an incorrect calculation and the commit [0] is needed on stable branches to correct this?

Thanks.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=2119876

[0]
commit 22572e84fbda2c195707ffbb0dd6af4433d7a219

Author: John Daley <[email protected]>
Date:   Fri Jan 28 09:58:13 2022 -0800

net/enic: support max descriptors allowed by adapter

Newer VIC adapters have the max number of supported RX and TX descriptors in their configuration. Use these values as the maximums.

Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.
Reviewed-by Hyong Youb Kim
#2 lore raw

Thank you, I will take a look and get back to you. -john

From: Kevin Traynor <[email protected]>
Date: Wednesday, March 15, 2023 at 10:47 AM
To: John Daley (johndale) <[email protected]>, Hyong Youb Kim (hyonkim) <[email protected]>
Cc: Luca Boccassi <[email protected]>, David Marchand <[email protected]>, [email protected] <[email protected]>
Subject: Fwd: [Bug 1185] enic: no longer accepting 2048 descriptor size in 20.11.6
Hi John/Hyong Youb,

Not sure if you are monitoring dpdk bugzilla, but wanted to draw your attention to https://bugs.dpdk.org/show_bug.cgi?id=1185

Maybe you have some clues about it and if we need to backport the mentioned commit?

thanks,
Kevin.

-------- Forwarded Message --------
Subject: [Bug 1185] enic: no longer accepting 2048 descriptor size in 20.11.6
Date: Wed, 15 Mar 2023 17:33:52 +0000
From: [email protected]
To: [email protected]

https://bugs.dpdk.org/show_bug.cgi?id=1185

             Bug ID: 1185
            Summary: enic: no longer accepting 2048 descriptor size in
                     20.11.6
            Product: DPDK
            Version: 20.11
           Hardware: All
                 OS: All
             Status: UNCONFIRMED
           Severity: normal
           Priority: Normal
          Component: core
           Assignee: [email protected]
           Reporter: [email protected]

Target Milestone: ---

Hi enic maintainers,

With openvswitch 2.15 using dpdk 20.11.6, enic driver is reporting that it cannot accept setup with default OVS number of tx descriptors (2048).

2022-08-19T16:29:38.555Z|00204|dpdk|ERR|Invalid value for nb_tx_desc(=2048),

should be: <= 256, >= 64, and a product of 32

OVS has used 2048 as default for many years and the code in 20.11.6 does not look like it changed much from previous releases either.

The commit below [0] on dpdk main branch (but not on 20.11 branch), changes how
max descriptor values are calculated.

So any idea why the 2048 can no longer be used with 20.11.6 ? some commit I missed? different firmware?

or is it an incorrect calculation and the commit [0] is needed on stable branches to correct this?

Thanks.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=2119876

[0]
commit 22572e84fbda2c195707ffbb0dd6af4433d7a219

Author: John Daley <[email protected]>
Date:   Fri Jan 28 09:58:13 2022 -0800

net/enic: support max descriptors allowed by adapter

Newer VIC adapters have the max number of supported RX and TX descriptors in their configuration. Use these values as the maximums.

--
You are receiving this mail because:
You are the assignee for the bug.